feat: Improve barretenberg headers#201
Merged
Merged
Conversation
|
Looks mostly good to me. We should ping the crypto team letting them know about this PR because it will likely break people's branches. But I do think this is a good change. It might make sense to move some of the C++ formatting changes into a separate PR, but I don't feel strongly either way. |
Author
|
The formatting changes happened because I moved the files and the git hook applies to all files that are staged (see #192). I think it's fine to format them so all formatting is consistent as per the git hook. |
ludamad
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Jul 22, 2023
* fix!: Move the include root up 1 directory & rename aztec to barretenberg * chore: Use quote includes instead of angle brackets
ludamad
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Jul 24, 2023
* fix!: Move the include root up 1 directory & rename aztec to barretenberg * chore: Use quote includes instead of angle brackets
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR does a few things:
cpp/src/aztectocpp/src/barretenberg, which will align the installed headers to match thelibbarretenberglibrary that will get installed by feat: Add installation targets for libbarretenberg, wasm & headers #185cpp/src/aztec/CMakeLists.txttocpp/src/CMakeLists.txtwhich allows all header files to be prefixed with thebarretenbergnamespace. This ensures that header includes when building the project are the same as when installed.barretenberg/prefix.Checklist:
/markdown/specshave been updated.@briefdescribing the intended functionality.